fix notification filter for managers. Fixes #919

src/Domain/Notification/Controller/NotificationController.php

@@ -29,6 +29,7 @@ use App\Application\Symfony\Security\UserProvider;
 use App\Application\Traits\ServersideDatatablesTrait;
 use App\Domain\Notification\Model;
 use App\Domain\Notification\Model\Notification;
+use App\Domain\Notification\Model\NotificationUser;
 use App\Domain\Notification\Repository;
 use App\Domain\User\Dictionary\UserMoreInfoDictionary;
 use App\Domain\User\Dictionary\UserRoleDictionary;
@@ -274,7 +275,7 @@ class NotificationController extends CRUDController
                 $notification->setReadAt(new \DateTime());
                 $notification->setReadBy($this->getUser());
             } else {
-                $nu = $notification->getNotificationUsers()->filter(function ($i, $n) use ($user) {
+                $nu = $notification->getNotificationUsers()->filter(function ($n) use ($user) {
                     /* @var Model\NotificationUser $n */
                     return $n->getUser() && $n->getUser()->getId() === $user->getId();
                 })->first();
@@ -331,6 +332,7 @@ class NotificationController extends CRUDController
      */
     public function markAsUnreadAction(Request $request, string $id)
     {
+        /** @var Notification $notification */
         $notification = $this->repository->findOneByID($id);
         if (!$notification) {
             throw new NotFoundHttpException('Notification introuvable');
@@ -342,8 +344,7 @@ class NotificationController extends CRUDController
             $this->entityManager->flush();
         } else {
             $user = $this->userProvider->getAuthenticatedUser();
-            $nu   = $notification->getNotificationUsers()->filter(function ($i, $n) use ($user) {
-                /* @var Model\NotificationUser $n */
+            $nu   = $notification->getNotificationUsers()->filter(function (NotificationUser $n) use ($user) {
                 return $n->getUser() && $n->getUser()->getId() === $user->getId();
             })->first();
             if ($nu) {