From 92f2d5fb36a56bc27f704a464815f7525fe11684 Mon Sep 17 00:00:00 2001
From: Fabien COMBERNOUS <fabien.combernous@adullact.org>
Date: Sun, 18 Nov 2018 20:51:53 +0100
Subject: [PATCH] use structured fact and case statement

---
 manifests/helpers/flushcache.pp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/manifests/helpers/flushcache.pp b/manifests/helpers/flushcache.pp
index 3671c4c..8beb7ed 100644
--- a/manifests/helpers/flushcache.pp
+++ b/manifests/helpers/flushcache.pp
@@ -6,15 +6,17 @@
 define freeipa::helpers::flushcache {
 
   #TODO: nscd should be called on both platforms.
-  if $::osfamily == 'RedHat' {
-    $ipa_fluch_cache_cmd = "\
+  case $facts['os']['family'] {
+    'RedHat': {
+      $ipa_fluch_cache_cmd = "\
 if [ -x /usr/sbin/sss_cache ]; then \
   /usr/sbin/sss_cache -UGNA >/dev/null 2>&1 ; \
 else \
   /usr/bin/find /var/lib/sss/db -type f -exec rm -f \"{}\" ; ; \
 fi"
-  } elsif $::osfamily == 'Debian' {
-    $ipa_fluch_cache_cmd = "\
+    }
+    'Debian': {
+      $ipa_fluch_cache_cmd = "\
 if [ -x /usr/sbin/nscd ]; then \
   /usr/sbin/nscd -i passwd -i group -i netgroup -i automount >/dev/null 2>&1 ; \
 elif [ -x /usr/sbin/sss_cache ]; then \
@@ -22,8 +24,10 @@ elif [ -x /usr/sbin/sss_cache ]; then \
 else \
   /usr/bin/find /var/lib/sss/db -type f -exec rm -f \"{}\" ; ; \
 fi"
-  } else {
-    fail('The class freeipa::flushcache is only written for RedHat and Debian.')
+    }
+    default: {
+      fail('The class freeipa::flushcache is only written for RedHat and Debian.')
+    }
   }
 
   exec { "ipa_flushcache_${title}":
-- 
2.24.1