Merge branch '6-remove-useless-parameters' into 'master'

Resolve "Remove useless parameters"

Closes #6

See merge request amies/puppet-amies!3

manifests/init.pp

@@ -43,25 +43,26 @@ class amies (
   String $db_user_password,
   Array $package_list, # Value of $package_list are specified in Hiera
 
-  String $gitlab_srv          = 'gitlab.adullact.net',
-  String $gitlab_group        = 'amies',
-  String $gitlab_project_name = 'amies-server',
-  String $gitlab_branch       = 'master',
-  String $db_host             = 'localhost',
-  Integer $db_port            = 5432,
-  String $db_name             = 'amies',
-  String $db_for_tests_name   = 'amies_test',
-  String $db_user_name        = 'amies',
-  String $system_username     = 'amies',
+  String $gitlab_branch     = 'master',
+  String $db_host           = 'localhost',
+  Integer $db_port          = 5432,
+  String $db_name           = 'amies',
+  String $db_for_tests_name = 'amies_test',
+  String $db_user_name      = 'amies',
+  String $system_username   = 'amies',
   # Activate debug / dev mode
-  Boolean $debug              = false,
+  Boolean $debug            = false,
 ) {
 
   # #############################################################################
   # Variables
 
+  $_gitlab_srv = 'gitlab.adullact.net'
+  $_gitlab_group = 'amies'
+  $_gitlab_project_name = 'amies-server'
+
   # URL of AMIES source code repository
-  $_amies_gitlab_full_url = "${gitlab_srv}/${gitlab_group}/${gitlab_project_name}"
+  $_amies_gitlab_full_url = "${_gitlab_srv}/${_gitlab_group}/${_gitlab_project_name}"
   # URL of AMIES jar file (grabbed from a CI job)
   # see https://docs.gitlab.com/ee/user/project/pipelines/job_artifacts.html#downloading-the-latest-artifacts
   $_amies_jar_url = join(