diff --git a/README.md b/README.md index 2602104ede8d361335759d0d735309caa4120700..1d96794e42df8936abc1d16577e572c740100e9c 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,11 @@ Acceptance tests are done : * with Ubuntu 18.06 for FreeIPA clients . +With follwoing issue not fixed the acceptance tests about tasks are disabled : +https://github.com/puppetlabs/beaker-task_helper/issues/47 +PR : https://github.com/puppetlabs/beaker-task_helper/pull/48 + + Puppet4 is EOL since 2019-01-01. Even if puppet 4.10 should work, it is not tested. ## Development diff --git a/spec/acceptance/02_manage_admin_spec.rb b/spec/acceptance/02_manage_admin_spec.rb index c9d89869e9c6649ce2d42f46a0ce59f3137a5b89..36657c6cf0f68ef2a9a65ae38753590f1677eda8 100644 --- a/spec/acceptance/02_manage_admin_spec.rb +++ b/spec/acceptance/02_manage_admin_spec.rb @@ -2,54 +2,52 @@ require 'spec_helper_acceptance' require 'beaker-task_helper/inventory' require 'bolt_spec/run' -describe 'manage_admin task' do - include Beaker::TaskHelper::Inventory - include BoltSpec::Run - - def bolt_config - { 'modulepath' => File.join(File.dirname(File.expand_path(__FILE__)), '../', 'fixtures', 'modules') } - end - - def bolt_inventory - hosts_to_inventory - end - - context 'with ensure present' do - it 'creates admin account' do - # rubocop:disable Style/BracesAroundHashParameters - result = run_task( - 'freeipa::manage_admin', - 'master', - { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'present', 'login' => 'jaimarre', 'firstname' => 'Jean', 'lastname' => 'Ai marre', 'password' => 'adminsecret' } - ) - # rubocop:enable Style/BracesAroundHashParameters - expect(result.first).to include('status' => 'success') - end - end - - context 'with ensure absent on existing existing' do - it 'deletes admin account' do - # rubocop:disable Style/BracesAroundHashParameters - result = run_task( - 'freeipa::manage_admin', - 'master', - { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'absent', 'login' => 'jaimarre' } - ) - # rubocop:enable Style/BracesAroundHashParameters - expect(result.first).to include('status' => 'success') - end - end - - context 'with ensure absent on NOT existing account' do - it 'deletes admin account' do - # rubocop:disable Style/BracesAroundHashParameters - result = run_task( - 'freeipa::manage_admin', - 'master', - { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'absent', 'login' => 'jaimarre' } - ) - # rubocop:enable Style/BracesAroundHashParameters - expect(result.first).to include('status' => 'success') - end - end -end +# With follwoing issue not fixed the acceptance tests about tasks are disabled : +# https://github.com/puppetlabs/beaker-task_helper/issues/47 +# PR : https://github.com/puppetlabs/beaker-task_helper/pull/48 +# +# describe 'manage_admin task' do +# include Beaker::TaskHelper::Inventory +# include BoltSpec::Run +# +# def bolt_config +# { 'modulepath' => File.join(File.dirname(File.expand_path(__FILE__)), '../', 'fixtures', 'modules') } +# end +# +# def bolt_inventory +# hosts_to_inventory +# end +# +# context 'with ensure present' do +# it 'creates admin account' do +# result = run_task( +# 'freeipa::manage_admin', +# 'master', +# { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'present', 'login' => 'jaimarre', 'firstname' => 'Jean', 'lastname' => 'Ai marre', 'password' => 'adminsecret' } +# ) +# expect(result.first).to include('status' => 'success') +# end +# end +# +# context 'with ensure absent on existing existing' do +# it 'deletes admin account' do +# result = run_task( +# 'freeipa::manage_admin', +# 'master', +# { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'absent', 'login' => 'jaimarre' } +# ) +# expect(result.first).to include('status' => 'success') +# end +# end +# +# context 'with ensure absent on NOT existing account' do +# it 'deletes admin account' do +# result = run_task( +# 'freeipa::manage_admin', +# 'master', +# { 'operator_login' => 'admin', 'operator_password' => 's^ecr@et.ea;R/O*=?j!.QsAu+$', 'ensure' => 'absent', 'login' => 'jaimarre' } +# ) +# expect(result.first).to include('status' => 'success') +# end +# end +# end